search

ayal / headly

meteor package to handle facebookexternalhit responses (for og:metatags use)
28 stars 7 forks source link

Code from mrt is bugged #2

Closed fjsj closed 11 years ago

fjsj commented 11 years ago

The code hosted at Atmosphere is bugged.

I've did mrt add headly and the line 11 of downloaded code is: Meteor.headly._options = Meteor.headly._options; instead of Meteor.headly._options = options || Meteor.headly._options; which is the correct version.

ayal commented 11 years ago

@fjsj I'm so sorry this is embarrassing. I honestly don't know what was the exact problem with the publish process to Atmosphere since the master code was the correct way, i.e:

 Meteor.headly._options = options || Meteor.headly._options;

you can try to remove and re-install the package or specifically version 0.0.42:

mrt remove headly 
mrt add headly --version 0.0.42

or if this for some reason doesn't work (I've had Atmosphere insisting on installing v0.0.3 for about an hour) you can try changing the code yourself..

fjsj commented 11 years ago

No problem, I've bundled the master code in a lib directory of my project. Thanks for this great lib! I've just wanted to report the issue to you.