search

ayamir / nvimdots

A well configured and structured Neovim.
BSD 3-Clause "New" or "Revised" License
2.91k stars 458 forks source link

feat(plugins): migrate from `null-ls` to `none-ls` #1088

Closed Jint-lzxy closed 10 months ago

Jint-lzxy commented 10 months ago

IMO we can switch to none-ls before we decide on the best alternative to null-ls b/c it's a drop-in replacement for null-ls, and we can continue to receive future bug fixes as well.

YuCao16 commented 10 months ago

Can we consider other alternatives like conform.nvim, the advantages of which seem attractive. https://github.com/ayamir/nvimdots/issues/851#issuecomment-1836305987

Mythos-404 commented 10 months ago

conform.nvim provides format_on_save and format_after_save to make it easier to customize the formatting of the save, and to add unsupported formatting programs.

my fork repository configuration can be used as a reference,please forgive me if the code is written badly conform config formate config

ayamir commented 10 months ago

I tend to none-ls b/c we have too many stuffs binding with null-ls and none-ls is maintained by community now.

CharlesChiuGit commented 10 months ago

As @Mythos-404 stated:

After I replaced null-ls with conform.nvim I found that conform.nvim has these advantages over

  1. startup speed improvement
  2. performance improvement when formatting
  3. formatting without breaking code folding
  4. the ability to specify a range of formatting

Could u show us some profile numbers to let we know that's the trade-off? Or I can do it when I got time.

Tho there might be some attractive side of conform.nvim, as @YuCao16 said, i dont really see it as a replacement to null-ls.nvim. For example, null-ls provides "Code actions", "Hover" and so on to be configured; however, i dont see sth relatable in conform.nvim? (or did i missed it?) But i do appreciate the comprehensiveness of conform.nvim about formatting.

Continuity of the user experiences is also a big part when planing migrations, users with less experiences will pop up with A LOT OF issues. However, if it worth the pain, i think we'll all embrace the change!

Mythos-404 commented 10 months ago

Could u show us some profile numbers to let we know that's the trade-off?

This is my warehouse.

Use none-ls.nvim first, after all, null.nvim has not been maintained for too long.

Migrating null-ls.nvim to conform.nvim requires a lot of code changes, which is not cost-effective at the moment, after all, nvimdots has a mature null-ls.nvim configuration now.