search

ayamir / nvimdots

A well configured and structured Neovim.
BSD 3-Clause "New" or "Revised" License
2.83k stars 451 forks source link

[none-ls] Deprecating builtins with unmaintained upstream or native LSP replacement #1183

Closed CharlesChiuGit closed 3 months ago

CharlesChiuGit commented 4 months ago

image

https://github.com/nvimtools/none-ls.nvim/discussions/81 https://github.com/nvimtools/none-ls.nvim/pull/77

That PR will lead to some changes to our format/linting mechanism, since we explicitly disable formatting ability form LSs.

I suggest doing the following:

  1. Pin none-ls' commit 'til further decision is made.
  2. Decide to use other format/ linting management plugin or change our lua/modules/configs/completion/formatting.lua to comply w/ none-ls.
CharlesChiuGit commented 4 months ago

https://github.com/nvimtools/none-ls.nvim/commit/f81edad87bc6c1a4e675e8e97b22a62939ad4ade

csyJoy commented 4 months ago

Should we pin the previous commit of this commit? the warning message is just annoying

CharlesChiuGit commented 4 months ago

@csyJoy

Should we pin the previous commit of this commit? the warning message is just annoying

I choose this commit b/c i think we need to let users know that they might need to update their user config. yeah, i know it's a bit annoying, but it still serve as a reminder tho.

JohnWickzzz commented 4 months ago

The latest commit https://github.com/nvimtools/none-ls.nvim/commit/793c6071621814c61a14c24cdb43e9badd88f0af add a way to supress the deprecation warning, I think it's better for use.

ayamir commented 4 months ago

I tend to just remove rustfmt for us and keep using none-ls. Users should do their own changes for upstream changes.