search

ayan-biswas0412 / gssoc2021-HotelOnTouch

👨‍🔧👨‍🔧Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributors👨‍🔧👩‍🏫
https://hotelontouch.netlify.app
GNU General Public License v3.0
70 stars 82 forks source link

Added various security features issue #115 #117

Closed udaymittal7 closed 3 years ago

udaymittal7 commented 3 years ago

Added helmet for security http headers. Added rate limiter to receive 100 requests per hour from a particular IP address. Added mongo sanitize for data sanitization against noSQL query injection Added xss for data sanitization against XSS.

Please review and if any changes required let me know. Thank you.

For issue #115

welcome[bot] commented 3 years ago

🧑‍💻👩‍💻 Thanks for opening this pull request! Please check out our contributing guidelines.🥳🥳 Please be patient our project maintainers will be get back to you soon and till then you can differenct issues listed here And Please make sure you have completed the Onboarding Process.

udaymittal7 commented 3 years ago

I am new to git. Can you tell me how to remove this commit from the pull request. Thank you.

ayan-biswas0412 commented 3 years ago

I am new to git. Can you tell me how to remove this commit from the pull request. Thank you.

REFER https://www.git-tower.com/learn/git/faq/undo-last-commit/

udaymittal7 commented 3 years ago

I made the change. Please check. Thank you for the help.

udaymittal7 commented 3 years ago

@ayan-biswas0412 I always get stuck when these conflicts occur. Please guide how to solve them.

udaymittal7 commented 3 years ago

I resolved the conflicts.

udaymittal7 commented 3 years ago

your code is failing ci checks

How to resolve them?

ayan-biswas0412 commented 3 years ago

your code is failing ci checks

How to resolve them? click on the CI to see what are failing

udaymittal7 commented 3 years ago

It is just showing this check failing and nothing else.

ayan-biswas0412 commented 3 years ago

It is just showing this check failing and nothing else.

I have reinitiated ci jobs let's see what happens

udaymittal7 commented 3 years ago

It is showing all checks are cleared now. FInally.

ayan-biswas0412 commented 3 years ago

@singhayushh can you test this locally please ?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ayan-biswas0412 commented 3 years ago

@Doringl @singhayushh @aniketsingh98571 can you comment on this is this thing needed ?

aniketsingh98571 commented 3 years ago

@Doringl @singhayushh @aniketsingh98571 can you comment on this is this thing needed ?

Hey @ayan-biswas0412 , I am not a good backend guy I think @singhayushh will be a good person to manage this.

singhayushh commented 3 years ago

If you are looking ahead to push this project as a live product, you can use these security packages to prevent DDoS attacks on the website.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.