ayan-biswas0412 / gssoc2021-HotelOnTouch

👨‍🔧👨‍🔧Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributors👨‍🔧👩‍🏫
https://hotelontouch.netlify.app
GNU General Public License v3.0
70 stars 82 forks source link

feat: Add style to jumbotron #126

Closed ankitaugale23 closed 3 years ago

ankitaugale23 commented 3 years ago

Jumbotron was having minimal styling soo added some styling to it and its contents. This will fix issue #104

Fixes #

  1. Add the card type shadow effect to the jumbotron
  2. Add Typing effect to the header of the jumbotron for laptop/desktop screen
  3. Change the button color to black(so the GitHub can look better)
  4. found the text on the button having spelling mistake so just fixed that(not mentioned in commit as it was a very minor change

**Added two libraries to package.json (react-socks) and (react-typewriter).

Screenshots of the changes (If any) - https://drive.google.com/file/d/1DXyxdoeXY1zcAcmexaRzuCgOQmNZibbS/view?usp=sharing Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

✅️ By submitting this PR, I have verified the following

welcome[bot] commented 3 years ago

🧑‍💻👩‍💻 Thanks for opening this pull request! Please check out our contributing guidelines.🥳🥳 Please be patient our project maintainers will get back to you soon and till then you can find different issues listed here And Please make sure you have completed the Onboarding Process.

ankitaugale23 commented 3 years ago

Let me know if any changes required further. @ayan-biswas0412

aniketsingh98571 commented 3 years ago

@ankitaugale23 Unexpected whitespace at end of line (no-eol-whitespace) lines of code = 1 Found in hotelontouch\src\App.css:57 57 letter-spacing: .001em; Unexpected whitespace at end of line (no-eol-whitespace) lines of code = 1 Found in hotelontouch\src\App.css:53 53 overflow: hidden; Unexpected whitespace at end of line (no-eol-whitespace) lines of code = 1 Found in hotelontouch\src\App.css:58 58 animation: Unexpected whitespace at end of line (no-eol-whitespace) lines of code = 1 Found in hotelontouch\src\App.css:55 55 white-space: nowrap; Unexpected whitespace at end of line (no-eol-whitespace) lines of code = 1 Found in hotelontouch\src\App.css:54 54 border-right: .10em solid black; Here is the error which you are getting, please remove the unnecessary whitespace....

aniketsingh98571 commented 3 years ago

@ayan-biswas0412 I have also added some guidelines regarding the CI checks in the discussion section on the topic CI/CD, so in the readme.MD you can add this thing that First read the CI/CD guidelines to avoid failing of CI checks...

ankitaugale23 commented 3 years ago

I have updated the files and it has passed all the checks. Kindly check and let me know if there are any changes. @aniketsingh98571 @ayan-biswas0412

ankitaugale23 commented 3 years ago

don't commit the yarn.lock file

Done

ankitaugale23 commented 3 years ago

nice work

Thank you

welcome[bot] commented 3 years ago

🥳🥳Congrats on merging your first pull request! We here at HotelOnTouch are proud of you!🎉🎉🎉