Title has been added check once

ayan-biswas0412 / gssoc2021-HotelOnTouch

👨‍🔧👨‍🔧Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributors👨‍🔧👩‍🏫

https://hotelontouch.netlify.app

GNU General Public License v3.0

70 stars 82 forks source link

Title has been added check once #150

Closed Ruchip16 closed 3 years ago

Ruchip16 commented 3 years ago

Fixes #

Changes done

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

✅️ By submitting this PR, I have verified the following

[x] Worked on forked repo and starred the main repo
[ ] Checked to see if a similar PR has already been opened 🤔️
[x] Reviewed the contributing guidelines 🔍️
[ ] Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
[ ] Tried Squashing the commits into one

welcome[bot] commented 3 years ago

🧑‍💻👩‍💻 Thanks for opening this pull request! Please check out our contributing guidelines.🥳🥳 Please be patient our project maintainers will get back to you soon and till then you can find different issues listed here And Please make sure you have completed the Onboarding Process.

Ruchip16 commented 3 years ago

Ok ci checks means ??

ayan-biswas0412 commented 3 years ago

Ok ci checks means ??

see below it is saying some checks are failing

aniketsingh98571 commented 3 years ago

Ok ci checks means ??

@Ruchip16 CI means Continous Integration.....It basically checks whether your code is good enough in terms of good practices of writing code, if your code will be merged to the main then it will not affect the whole project structure, and so on... CI is a deep concept under DevOps and it's mostly used to automate tasks which GitHub uses a lot...

aniketsingh98571 commented 3 years ago

@Ruchip16 'renderCard' is assigned a value but never used. lines of code = 1 Read Up Found in hotelontouch\src\components\AdminCard.js:63 63 const renderCard = (card, index) => { this is the error which you are getting please fix it...

Ruchip16 commented 3 years ago

@ayan-biswas0412 Ya I will fix that issue

Ruchip16 commented 3 years ago

@aniketsingh98571 but I am not able to understand where should I call rendercard

Ruchip16 commented 3 years ago

@ayan-biswas0412 I have added title check now

Ruchip16 commented 3 years ago

@ayan Biswas can u please elaborate on which changes do I need to make or put some screenshots or something like that so that I can work there it would be very much helpful coz u said you will review or suggest changes only after making a PR so plz elaborate

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.