Added applaunch Page, fixes issue #123

ayan-biswas0412 / gssoc2021-HotelOnTouch

👨‍🔧👨‍🔧Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributors👨‍🔧👩‍🏫

https://hotelontouch.netlify.app

GNU General Public License v3.0

70 stars 82 forks source link

Added applaunch Page, fixes issue #123 #151

Closed abhishek7997 closed 3 years ago

abhishek7997 commented 3 years ago

type: fix

Fixes #123

Changes done

[1] Added AppLaunch.js in components folder
[2] Added '/applaunch' route in App.js
[3] Added AppLaunch.js page in '/pages' and in 'index.js'

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

✅️ By submitting this PR, I have verified the following

[x] Worked on forked repo and starred the main repo
[x] Checked to see if a similar PR has already been opened 🤔️
[x] Reviewed the contributing guidelines 🔍️
[x] Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
[x] Tried Squashing the commits into one

abhishek7997 commented 3 years ago

@ayan-biswas0412 Sir please check my PR as well

abhishek7997 commented 3 years ago

why no deploy previews are not created by netlify ? can you debug ?

@ayan-biswas0412 Sir, I don't know what this netlify thing, or the checks are, or how they work, please help.

ayan-biswas0412 commented 3 years ago

why no deploy previews are not created by netlify ? can you debug ?

@ayan-biswas0412 Sir, I don't know what this netlify thing, or the checks are, or how they work, please help.

when you raise a PR netlify builds deploy preview automatically but in your case no deploy preview is created so I am unable to test your PR

abhishek7997 commented 3 years ago

@ayan-biswas0412 Sir, I have no idea how to go about this. Should I delete my forked repo and fork and clone a new one and make a new PR? I believe you can check what all files have been changed in all of my 5 commits. Please check them and tell what should I do next.

ayan-biswas0412 commented 3 years ago

@ayan-biswas0412 Sir, I have no idea how to go about this. Should I delete my forked repo and fork and clone a new one and make a new PR? I believe you can check what all files have been changed in all of my 5 commits. Please check them and tell what should I do next.

yah you can do that

abhishek7997 commented 3 years ago

Should I close this PR then?

abhishek7997 commented 3 years ago

@ayan-biswas0412 Please check my new PR