Added applaunch page, fixes issue #123

ayan-biswas0412 / gssoc2021-HotelOnTouch

👨‍🔧👨‍🔧Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributors👨‍🔧👩‍🏫

https://hotelontouch.netlify.app

GNU General Public License v3.0

70 stars 82 forks source link

Added applaunch page, fixes issue #123 #154

Closed abhishek7997 closed 3 years ago

abhishek7997 commented 3 years ago

type: fix

Fixes #123

Changes done

[1] Added AppLaunch.js in components folder
[2] Added '/applaunch' route in App.js
[3] Added AppLaunch.js page in '/pages' and in 'index.js'

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

✅️ By submitting this PR, I have verified the following

[x] Worked on forked repo and starred the main repo
[x] Checked to see if a similar PR has already been opened 🤔️
[x] Reviewed the contributing guidelines 🔍️
[x] Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
[x] Tried Squashing the commits into one

abhishek7997 commented 3 years ago

@ayan-biswas0412 Please check this new PR.

abhishek7997 commented 3 years ago

@ayan-biswas0412 Please check the new commit

abhishek7997 commented 3 years ago

@ayan-biswas0412 The problem with the previous setup was that the Theme Change button was hiding behind the container/jumbotron on the app launch page, but I will try if something works or not.

abhishek7997 commented 3 years ago

@ayan-biswas0412 Please check the new commit

abhishek7997 commented 3 years ago

@ayan-biswas0412 I am stuck here, the text on app launch page does not change upon toggling the theme, whereas it changes in homepage? Any idea why this is happening?

abhishek7997 commented 3 years ago

nice work

If it is OK, then please merge the PR. Thank you.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

abhishek7997 commented 3 years ago

@ayan-biswas0412 Its been at least 2 weeks since the PR was approved. Please give feedback on this PR. Or at least tell whether the PR is okay or not.

abhishek7997 commented 3 years ago

@ayan-biswas0412 Conflicts resolved

abhishek7997 commented 3 years ago

@ayan-biswas0412 please check the PR now.

abhishek7997 commented 3 years ago

@ayan-biswas0412 Can you please tell me how to update my forked repository without losing any changes that I made?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.