ayan-biswas0412 / gssoc2021-HotelOnTouch

πŸ‘¨β€πŸ”§πŸ‘¨β€πŸ”§Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributorsπŸ‘¨β€πŸ”§πŸ‘©β€πŸ«
https://hotelontouch.netlify.app
GNU General Public License v3.0
70 stars 82 forks source link

feat: Modified Navbar #155

Closed shawavisek35 closed 3 years ago

shawavisek35 commented 3 years ago

Fixes #141

Changes done

Screenshots of the changes (If any) - Screenshot from 2021-03-26 19-03-38 Screenshot from 2021-03-26 19-03-46

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

βœ…οΈ By submitting this PR, I have verified the following

welcome[bot] commented 3 years ago

πŸ§‘β€πŸ’»πŸ‘©β€πŸ’» Thanks for opening this pull request! Please check out our contributing guidelines.πŸ₯³πŸ₯³ Please be patient our project maintainers will get back to you soon and till then you can find different issues listed here And Please make sure you have completed the Onboarding Process.

shawavisek35 commented 3 years ago

create a folder inside components and keep the NavBar.js file inside it change the relative imports Also and create one file Nav.css keep your css codes there don't modify the App.css and also ci checks are failing please see them and open an issue for your work and link it here

I will do the required changes. And about the CI error, i have added a search bar in the navbar which is animated and therefore the width of the search box is 0 and when you hover at te search icon it will become wider so the error is showing in the width : 0 part. Is there anything I can do to bypass this?

ayan-biswas0412 commented 3 years ago

create a folder inside components and keep the NavBar.js file inside it change the relative imports Also and create one file Nav.css keep your css codes there don't modify the App.css and also ci checks are failing please see them and open an issue for your work and link it here

I will do the required changes. And about the CI error, i have added a search bar in the navbar which is animated and therefore the width of the search box is 0 and when you hover at te search icon it will become wider so the error is showing in the width : 0 part. Is there anything I can do to bypass this?

search stckoverflow

shawavisek35 commented 3 years ago

@ayan-biswas0412 I have done the required changes. please review my PR and let me know anything needs to be corrected. :)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

shawavisek35 commented 3 years ago

Hey @ayan-biswas0412 can you please merge this pr as ot will automatically get closer due to inactivity by the bot

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.