fix: Fix reloading problem of different paths

ayan-biswas0412 / gssoc2021-HotelOnTouch

👨‍🔧👨‍🔧Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributors👨‍🔧👩‍🏫

https://hotelontouch.netlify.app

GNU General Public License v3.0

70 stars 82 forks source link

fix: Fix reloading problem of different paths #161

Closed hsnice16 closed 3 years ago

hsnice16 commented 3 years ago

Fixes #

Changes done

Created a new folder constants in hotelontouch/src , and a new file constants/routes.js in it
In constants/routes.js , added path for home page and contact page
In App.js, instead of hard path, added reference path
In NavbarComponent.js, Converted Navbar.Brand and NavDropdown.Item as react-router-dom Link .

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

✅️ By submitting this PR, I have verified the following

[x] Worked on forked repo and starred the main repo
[x] Checked to see if a similar PR has already been opened 🤔️
[x] Reviewed the contributing guidelines 🔍️
[ ] Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
[x] Tried Squashing the commits into one

welcome[bot] commented 3 years ago

🧑‍💻👩‍💻 Thanks for opening this pull request! Please check out our contributing guidelines.🥳🥳 Please be patient our project maintainers will get back to you soon and till then you can find different issues listed here And Please make sure you have completed the Onboarding Process.

hsnice16 commented 3 years ago

the last point of changes done is the change that will prevent from reloading. Navbar.Brand and NavDropdown.Item (of contact us) will now work as react-router-dom Link

hsnice16 commented 3 years ago

In the third commit #e9cfedb, I tried to squash them in one. But still, it is showing 4 commits.

hsnice16 commented 3 years ago

Can you please help me, with that? And please merge this PR.

hsnice16 commented 3 years ago

Thanks for approving it.

hsnice16 commented 3 years ago

Please merge it.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

hsnice16 commented 3 years ago

@ayan-biswas0412 Please merge it

welcome[bot] commented 3 years ago

🥳🥳Congrats on merging your first pull request! We here at HotelOnTouch are proud of you!🎉🎉🎉

hsnice16 commented 3 years ago

@ayan-biswas0412 can you give gssoc and level label to PR, as I think without labels the PR is not countable. Thanks in advance.