ayan-biswas0412 / gssoc2021-HotelOnTouch

πŸ‘¨β€πŸ”§πŸ‘¨β€πŸ”§Manage your all hotel services at one place - This is the project repository for HotelOnTouch Project and this project is actively looking for new contributorsπŸ‘¨β€πŸ”§πŸ‘©β€πŸ«
https://hotelontouch.netlify.app
GNU General Public License v3.0
70 stars 82 forks source link

added Footer component and styles #178

Closed akshay1027 closed 3 years ago

akshay1027 commented 3 years ago

Fixes #172 Added 1)Find us with logo 2)Call us with logo 3)Mail us with logo 4)Website logo 5)What this website is about 6)Follow us -Instagram link with logo -LinkedIn link with logo -Twitter link with logo -etc 7)Useful links -Home -Services -About Us -Contact Us etc 8)Subscribe -Email address 9)Copyrights 10) All the above with responsive UI

Screenshots of the changes (If any) - window size is at 80% so that you can see full design:

2021-04-09 (2)

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

βœ…οΈ By submitting this PR, I have verified the following

welcome[bot] commented 3 years ago

πŸ§‘β€πŸ’»πŸ‘©β€πŸ’» Thanks for opening this pull request! Please check out our contributing guidelines.πŸ₯³πŸ₯³ Please be patient our project maintainers will get back to you soon and till then you can find different issues listed here And Please make sure you have completed the Onboarding Process.

akshay1027 commented 3 years ago

@ayan-biswas0412 please check this out! I have spent a day making this Footer!! Please let me know your opinion

aniketsingh98571 commented 3 years ago

@ayan-biswas0412 I think there is no need to modify the footer, because:-

  1. it is made using react-wavify so if we add anything that is a container it will break the whole structure.
  2. as per the contents mentioned by @akshay1027 I think you will not need that much content like subscribe, contact and find us.
akshay1027 commented 3 years ago

Yea you are correct, i tried but it did break the whole structure @aniketsingh98571 @ayan-biswas0412, i will try to modify existing footer itself, adding these many components wont work! Thanks

akshay1027 commented 3 years ago

Before changes:

2021-04-11 (8)_LI

2021-04-11 (9)

After Changes:

2021-04-11 (7)

2021-04-11 (6)

akshay1027 commented 3 years ago

If you approve this I shall make a new PR referencing this, @aniketsingh98571 @ayan-biswas0412, let me know what you think! Thank you!

aniketsingh98571 commented 3 years ago

If you approve this I shall make a new PR referencing this, @aniketsingh98571 @ayan-biswas0412, let me know what you think! Thank you!

please resolve the CI checks....

akshay1027 commented 3 years ago

this is old PR, i will close this and make new one!