search

ayende / rhino-licensing

A software licensing framework
http://ayende.com
BSD 3-Clause "New" or "Revised" License
336 stars 167 forks source link

Netstandard2.0 support in progress. #27

Closed dazinator closed 7 years ago

dazinator commented 7 years ago

Just opening this up in case you are interested. It's a work in progress, and not ready to merge - should you want to. I have begun updating the solution to add support for netstandard2.0. It doesn't fully compile yet as I need to figure out where WSHttpBinding went in the latest wcf packages for netstandard20.

dazinator commented 7 years ago

@ayende all tests passing now. I had to:

  1. Remove usages of WsHttpBinding in favour of BasicHttpBinding as former not available in wcf for netstandard2.0
  2. Remove log4net in favour of liblog. Liblog is compiled into the library but detects a logger configured by the application - so if applications ultimately want to use log4net this will still work, but they could also use serilog or other loggers supported by liblog.
  3. LicensingService is cross compiled out of the netstandard2.0 build - this is because InstanceContextMode attribute cant be found in wcf for netstandard2.0 anywhere. However for client usage this is not a problem, just means if you want to host the licencing service you still have to run under net40.
ayende commented 7 years ago

Hi, This isn't actively maintained, and we have moved away from using it. As these changes would make it easier for us to be comparability with out deployed applications, I suggest you maintain it in your fork.

dazinator commented 7 years ago

Ok, will do! Thanks