ayende / rhino-licensing

A software licensing framework
http://ayende.com
BSD 3-Clause "New" or "Revised" License
336 stars 167 forks source link

Add error handling to discovery host #31

Closed vlow closed 7 years ago

vlow commented 7 years ago

Setting the socket options in the DiscoveryHost class fails on some system configurations. The failure triggers a SocketException as described in issue #8. A first step to address this problem has been made by making the client discovery optional. Still, if you want to use the client discovery, you risk running into the above mentioned exception which will effectively take down the whole application.

This PR adds a little error handling which logs the failed address and the exception. If the error occurrs, the failed address is ignored and the initialization will resume with the next address. Logging more information about this problem is essential since it might give some insight in what actually causes the crash. That might give us enough information to eventually fix the filter and avoid the exception in the first place.

This PR also updates the NuGet binary to version 4.3.0 in order to support C# 6 language features.