search

ayende / rhino-licensing

A software licensing framework
http://ayende.com
BSD 3-Clause "New" or "Revised" License
333 stars 167 forks source link

Made AbstractLicenseValidator implement IDisposable #4

Closed stemarie closed 6 years ago

stemarie commented 11 years ago

Not sure what "fancy-word"-principle this seems to break but essentially every time you instantiate the AbstractLicenseValidator it would create a timer thread which would never be removed until the garbage collector did its job. This is a very strange behavior because it forces us to call DisableFutureChecks as if it was a dispose method. This opens up the license validator to be used in bigger server environments.

stemarie commented 11 years ago

Sorry, not sure why it added all these commits (sorry) but essentially only ac279b4 should be the focus. Forgive my lack of gitness

DrivenLogic commented 11 years ago

@stemarie the correct way is you should do a pull at the correct version, create a branch. make your changes in that branch then submit a clean pull request from the branch. that way other commits wont be pulled along for the ride. :)

stemarie commented 11 years ago

Ok, I understand - sorry - I'm still learning Git's awesomeness