ayende / rhino-licensing

A software licensing framework
http://ayende.com
BSD 3-Clause "New" or "Revised" License
336 stars 167 forks source link

Subscription experation -4 days #7

Open stephencoombs opened 11 years ago

stephencoombs commented 11 years ago

Could you please exlain why you have the following line of code within ValidateSubscription? I have been testing an app using it and wanted to see what happens the day before and the day of expiration, but kept getting failures for both. Upon stepping through the code I found the following line, but there was no comment on the reason why expired is expired date plus four days?

if ((ExpirationDate - DateTime.UtcNow).TotalDays > 4)

ayende commented 11 years ago

It means, 4 days before the subscription license expire, check with the subscription service to get a new license. We usually generate subscription licenses with 3 days grace period, so you actually have that happen when we renew the subscription

On Wed, Sep 25, 2013 at 7:24 PM, stephencoombs notifications@github.comwrote:

Could you please exlain why you have the following line of code within ValidateSubscription? I have been testing an app using it and wanted to see what happens the day before and the day of expiration, but kept getting failures for both. Upon stepping through the code I found the following line, but there was no comment on the reason why expired is expired date plus four days?

if ((ExpirationDate - DateTime.UtcNow).TotalDays > 4)

— Reply to this email directly or view it on GitHubhttps://github.com/ayende/rhino-licensing/issues/7 .

stephencoombs commented 11 years ago

Cheers for getting back to me, did think that might be the case. I will just add abit of padding to the subscription date in that case, as I am not using a subscription service at this point.

ayende commented 11 years ago

How are you going to renew the subscription, then?

On Mon, Sep 30, 2013 at 1:51 AM, stephencoombs notifications@github.comwrote:

Cheers for getting back to me, did think that might be the case. I will just add abit of padding to the subscription date in that case, as I am not using a subscription service at this point.

— Reply to this email directly or view it on GitHubhttps://github.com/ayende/rhino-licensing/issues/7#issuecomment-25331051 .

stephencoombs commented 11 years ago

I was going to send out the subscription as a file that would be uploaded to the web site via a page, as I don't have a central web server for it to access.

ayende commented 11 years ago

What is your subscription period?

Oren Eini CEO Hibernating Rhinos Cellular: +972-52-548-6969 Office: +972-4-674-7811 Fax: +972-153-4622-7811

On Mon, Oct 28, 2013 at 6:15 PM, stephencoombs notifications@github.comwrote:

I was going to send out the subscription as a file that would be uploaded to the web site via a page, as I don't have a central web server for it to access.

— Reply to this email directly or view it on GitHubhttps://github.com/ayende/rhino-licensing/issues/7#issuecomment-27226461 .

stephencoombs commented 11 years ago

Its currently going to be 6 months but this might change to a year.

ayende commented 11 years ago

That is fine for the users, then.

Oren Eini CEO Hibernating Rhinos Cellular: +972-52-548-6969 Office: +972-4-674-7811 Fax: +972-153-4622-7811

On Tue, Oct 29, 2013 at 5:39 PM, stephencoombs notifications@github.comwrote:

Its currently going be 6 months but this might change to a year.

— Reply to this email directly or view it on GitHubhttps://github.com/ayende/rhino-licensing/issues/7#issuecomment-27313923 .