ayham95 / Custom-navigator

A flutter package that handles navigation deep in the widget tree
MIT License
80 stars 33 forks source link

CustomNavigator breaks the behavior of CupertinoSliverNavigationBar #10

Closed nicholasrq closed 4 years ago

nicholasrq commented 4 years ago

when using CustomNavigator, the behavior of CupertinoSliverNavigationBar breaks and those large titles are not animated on transition anymore

ezgif-7-f6af7e31406a

ayham95 commented 4 years ago

Did you set your pageRoute to PageRoutes.cupertinoPageRoute ??

nicholasrq commented 4 years ago

@ayham95 sure I did. unfortunately that doesn't fix anything

nicholasrq commented 4 years ago

@ayham95 it seems like sometimes nested widgets doesn't have access to a proper context and that causes the problem. i've also faced the issue when bottom navigation was rendered on top of the fullscreen modal. i've managed to fix that by passing the context of a widget that is holding a CustomNavigator down to a widget that triggers the navigation (calls Navigator.of(context))

ayham95 commented 4 years ago

I'll close this for now.. But welcome to be opened anytime.