ayham95 / Custom-navigator

A flutter package that handles navigation deep in the widget tree
MIT License
80 stars 33 forks source link

The non-abstract class '_CustomNavigatorState' is missing implementations #27

Open sgehrman opened 4 years ago

sgehrman commented 4 years ago

I just updated to the latest flutter beta:

../../../.pub-cache/hosted/pub.dartlang.org/custom_navigator-0.3.0/lib/custom_navigator.dart:60:7: Error: The non-abstract class '_CustomNavigatorState' is missing implementations for these members:

class _CustomNavigatorState extends State ^^^^^^^^^^^^^^^^^^^^^ ../../../google/flutter/packages/flutter/lib/src/widgets/binding.dart:122:16: Context: 'WidgetsBindingObserver.didPushRouteInformation' is defined here. Future didPushRouteInformation(RouteInformation routeInformation) { ^^^^^^^^^^^^^^^^^^^^^^^ Failed to compile application. Exited (sigterm)

SKerencic commented 4 years ago

have the same issue..any updates?

shrutika-tatkare-apptware commented 4 years ago

have the same issue..any updates?

ghost commented 4 years ago

Same here, does someone have any update on this ?

iNoles commented 4 years ago
@override
  Future<bool> didPushRouteInformation(RouteInformation routeInformation) {
    return didPushRoute(routeInformation.location);
  }
micheleferraro commented 4 years ago

Thanks @iNoles, it works, adding the implementation in custom_navigator.dart solves the problem.

shrutika-tatkare-apptware commented 4 years ago

Hey, Thanks @iNoles it worked

shrutika-tatkare-apptware commented 4 years ago

Please bring new version with this change in plugin ASAP

iNoles commented 4 years ago

I did tested with it and introduced a new bug.

The method 'call' was called on null.
Receiver: null
Tried calling: call()

on widget.onItemTap(index);

kjawadDeveloper commented 4 years ago

Use this in your pubspec.yaml

 custom_navigator:
    git:
      url: https://github.com/kjawadDeveloper/Custom-navigator.git
seenewmax commented 4 years ago

@kjawadDeveloper You saved my day. Thank you.

seenewmax commented 4 years ago

Use this in your pubspec.yaml

 custom_navigator:
    git:
      url: https://github.com/kjawadDeveloper/Custom-navigator.git

This solution solved the build error but seems to cause another problem. When a tab item is clicked, it is supposed to show the tab page immediately but if several pages are stacked up by Navigator.push, they only gets Navigator.pop.

Changed the package to another one. I found this okay. https://pub.dev/packages/persistent_bottom_nav_bar

iNoles commented 4 years ago

Use this in your pubspec.yaml

 custom_navigator:
    git:
      url: https://github.com/kjawadDeveloper/Custom-navigator.git

This solution solved the build error but seems to cause another problem. When a tab item is clicked, it is supposed to show the tab page immediately but if several pages are stacked up by Navigator.push, they only gets Navigator.pop.

Changed the package to another one. I found this okay. https://pub.dev/packages/persistent_bottom_nav_bar

I did have same problem too.

manudevcode commented 3 years ago

It works the solution of @iNoles 👍🏽