aykutkardas / react-icomoon

It makes it very simple to use SVG icons in your React and React-Native projects.

https://svgps.app

MIT License

216 stars 22 forks source link

Add types for typescript #9

Closed iezepov closed 3 years ago

iezepov commented 4 years ago

It's always nice to have type information and it would be great to have type information for this awesome package.

I'm thinking to create @types/react-icomoon or maybe even better to just re-write this project (well, single js file) to TypeScript. Then users will know props just from autocompletion for example.

What do you think?

aykutkardas commented 4 years ago

A great idea. Instead of creating a dependency for this small component or rewriting this component with typescript, it can be sufficient to create only an index.d.ts file.

davidkhierl commented 4 years ago

any pr for this?

aykutkardas commented 4 years ago

any pr for this?

No for now. If there is no help from the community, I will solve it this week. @davidkhierl

davidkhierl commented 3 years ago

any pr for this?

No for now. If there is no help from the community, I will solve it this week. @davidkhierl

seems the recent publish are not properly typed hence had some problem in my project so I made a pr to fully type the project.

13

aykutkardas commented 3 years ago

I'm sorry it's so late. TypeScript support is now ready.

v2.3.0