search

aymanalhattami / filament-page-with-sidebar

Organize pages in the sidebar in order to make navigation between pages more comfortable.
https://github.com/aymanalhattami/filament-page-with-sidebar
MIT License
175 stars 22 forks source link

fix: $isHidden has to be type Closure|bool #7

Closed bfiessinger closed 1 year ago

bfiessinger commented 1 year ago

Type of AymanAlhattami\FilamentPageWithSidebar\PageNavigationItem::$isHidden must be Closure|bool (as in class Filament\Navigation\NavigationItem)

https://github.com/filamentphp/filament/commit/25e8f95c00812d9856845fc0971abfcdeefa61ce

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aymanalhattami commented 1 year ago

Thank you for taking the time to create a pull request.

After reviewing the pull request and last release of filament, I noticed that the $isHidden and isHidden() method are in the filament NavigationItem class so they have been removed from PageNavigationItem class