aymanhab / opensim-gui-rcnl

SimTK OpenSim graphical user interface and distribution.
Apache License 2.0
0 stars 0 forks source link

Change names of menu items #30

Open aymanhab opened 2 months ago

aymanhab commented 2 months ago

Reported by BJ

Replace names as below Change “Joint Optimization…” to “Joint Model Personalization…” Change “Muscle Tendon Optimization…” to “Muscle-tendon Model Personalization…” Change “Neural Control Optimization…” to “Neural Control Model Personalization…” Change “Ground Contact Optimization…” to “Ground Contact Model Personalization…”

Question: Does including the word “Model” in each of the four menu selections above make each item too long? If so, we could omit the word “Model” from each selection, but including it makes everything clearer and more consistent.

Expected result

Actual result

(include screen grabs where appropriate)

Environment and GUI version

aymanhab commented 2 months ago

The names appeared too long, much longer than other commands in the GUI, I removed the word Model as in the follow up except for the first menu (Joint Model Personalization) as it becomes same length as the rest 3-word pattern also injects the word model to be implied for subsequent commands underneath though at the expense of some inconsistency. Thoughts?

aymanhab commented 2 months ago

CaptureRCNLPopup

aymanhab commented 2 months ago

@RobSalati

RobSalati commented 2 months ago

I think your proposed naming is good. It is in line with our tool acronyms (JMP, MTP, NCP, GCP), in which the only one that has "model" is JMP (joint model personalization).

aymanhab commented 2 months ago

fix submitted in https://github.com/aymanhab/opensim-gui-rcnl/pull/37