aymanhab / opensim-gui-rcnl

SimTK OpenSim graphical user interface and distribution.
Apache License 2.0
0 stars 0 forks source link

Add a checkbox to enable/disable synergy and torque controllers #41

Open RobSalati opened 2 months ago

RobSalati commented 2 months ago

Currently, the GUI always prints out fields for RCNLSynergyController and RCNLTorqueController regardless of if we use them.

This will cause errors upon parsing, and so these fields need to only print if the user wants them.

aymanhab commented 1 month ago

Will look into it, but would the empty flag of the controllers be a problem for your downstream code? Should we add a disabled/enabled flag so it fits with similar entities that are parsed but ignored downstream?

RobSalati commented 1 month ago

If the xml file is printed with the RCNLSynergyController field but does not have the elements fill in, the parsing will crash. I would prefer to not include the RCNLSynergyController or RCNLTorqueController fields in the xml at all if they are not explicitly enabled by the user.