aymara / lima

The Libre Multilingual Analyzer, a Natural Language Processing (NLP) C++ toolkit.
http://aymara.github.io/lima/
Other
104 stars 20 forks source link

tvx tests silently fail during GitHub Actions build #138

Open kleag opened 2 years ago

kleag commented 2 years ago

Describe the bug During github actions build, tvx is executed to check errors on xml analysis. Currently, it fails without causing a build error which is wrong.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github.com/aymara/lima/runs/6770311102?check_suite_focus=true#step:8:13852
  2. See that it failed without causing an error:
    #42 [37/44] RUN /bin/bash -c "set -o pipefail && tvx --language=eng --language=fre test-fre.xmlreader.xml 2>&1 | tee tvx-fre.log"
    #42 2.612 process tests in  "test-fre.xmlreader.xml"
    #42 2.614  : Common::AbstractProcessingClient : 2022-06-07T09:03:39.219 ERROR 0x55ec1dc92be0 "/src/lima/lima_common/src/common/Handler/AbstractProcessingClientHandler.h:52: AbstarctProcessingHandler::no Client for clientIdTITLE" 
    #42 2.614 caught LimaException : 
    #42 2.614 /src/lima/lima_common/src/common/Handler/AbstractProcessingClientHandler.h:52: AbstarctProcessingHandler::no Client for clientIdTITLE
    #42 2.614 
    #42 2.614 =========================================================
    #42 2.614 
    #42 2.614   TestReport :   test-fre.xmlreader.xml 
    #42 2.614 
    #42 2.614   type            success cond.   failed  total
    #42 2.614 ---------------------------------------------------------
    #42 2.614   bloquant        0   0   0   1
    #42 2.614 ---------------------------------------------------------
    #42 2.614   total           0   0   0   1
    #42 2.614 =========================================================

Expected behavior The GitHub Action should stop on error

Thanks to @romaricb for pointing out this issue.