aymeric-giraudet / svelte-algolia-instantsearch

A Svelte component library for Algolia InstantSearch.js
https://svelte-algolia-instantsearch.vercel.app/
MIT License
52 stars 12 forks source link

fix: component would fail to load when using an instantsearch adapter #16

Closed djdembeck closed 1 year ago

djdembeck commented 1 year ago

Using an adapter such as Typesense, which doesn't have the addAlgoliaAgent function, could cause this component to not load.

Since this is just for the search user agent, it shouldn't be mission-critical if it fails to change the user agent string: https://www.algolia.com/doc/api-client/getting-started/customize/javascript/?client=javascript#custom-user-agents

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-algolia-instantsearch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2023 8:53pm
knd775 commented 1 year ago

Thanks, I was ready to fork the project over this

djdembeck commented 1 year ago

Hey @aymeric-giraudet just following up if you were able to re-review the changes I accepted. Thanks!

aymeric-giraudet commented 1 year ago

Hey @djdembeck, looks good ! Thanks ! I'll put this in the 0.10.1 release :)