aymericingargiola / repentance-run-tracker

The Binding Of Isaac: Repentance run tracker app
MIT License
17 stars 1 forks source link

Some small QoL changes #61

Open Shaniquaniminiquani opened 1 year ago

Shaniquaniminiquani commented 1 year ago

Took a small break from the game but came back to it. Believe the App got a couple of updates since then. Here are some changes I think would be nice to have:

1) Open items inside of browser instead of inside of app:

I believe this is actually how it worked before, unsure if it's a bug or a feature but currently it opens inside of the app like this:

image the issue being that ads are displayed and it's just slightly more intrusive to keep a additional window open than a tab for me (Usually I'd want to keep it up for a bit). Didn't see this documented in the changelogs so maybe it's a bug? unsure.

2) Lock scrolling inside of the floors area:

![image](https://user-images.githubusercontent.com/109847642/218240947-2dbf4388-e3e9-40af-aceb-41acbfccd77a.png)

when you scroll inside of this area it moves the slider right/left which is intended but when it hits the end on either direction it then scrolls the entire window which is a bit annoying and I think also not intended. The desired outcome would be to not have it scroll the window when it has reached either end.

3) Make app go into a more compact(smaller) mode when in a current run:

I saw in the update [0.7.21] that the app now only shows your current run while doing one. I believe this was done for optimization reasons, you said by default it now only shows one run and disables filters. I don't particularly mind this albeit I'd prefer to see all runs or at least the first page but if it's only going to show one run while in game, I'd rather it to become smaller to only show that one run (if that makes sense). Ie. instead of displaying all of this 

image have it only display the essentials. Ie this: image Now ideally this would be made (dimensionally atleast) slightly more compact akin to something like the rebirth item tracker / perhaps have a darker version for specifically this mode in mind.

Alternatively if you didn't want to mess too much with creating a new mode with a smaller layout you can also just remove the minimum window size/ reduce it in the app so that I can make something similar to it. Currently this is as small as I can make the app vertically 

image Which as you can see has a lot of dead space since you're locked out of filters and you wouldn't need to see the streak save since it shows it on the actual current run

(Edit: 2/13/23)

4) Make resetting a run not get automatically deleted:

Holding R on a run clears the winstreak in the game but it doesn't on the tracker, this stems from the tracker completely ignoring these runs (They aren't deleted, they're just never saved). Ideally they would record either marking them as losses or with a new run status of "reset" which could either share/ take the icon from safe file :

image Although I don't know what the save file's icon could be replaced with seeing as how we're going for an isaac item theme. Perhaps a slightly modified adoption papers? Theres some other decent ones like deaths list / missing page/ cartridge but think they might have too much going on visually.

I personally don't ever hold R so I hadn't noticed until now but got softlocked and was pretty early into a streak so decided to reset. Only upon noticing the streak was still counting up on the tracker did I realize the run had banished completely. 

I think some people might prefer it not saving however so maybe this can be an option instead? Unsure. Another way to handle it would be to check if an item has been picked up/ a certain amount of time has elapsed.

I think a way to manually flag a run as the end of a winstreak (regardless of win/loss) / a way to manually clear a winstreak might also be a good safety net for this but it does seem *rare*

Its worth noting that during my testing to make sure this was how it (resetting runs) behaved I noticed 2 weird bugs, the first of which where no run would show while in a current run:

image This seemed rare, only happened 3 times and might be partially due to it being on a save that used to be ignored. Don't think its worth looking into since I wasn't able to replicate it reliably.

The second of which seems to happen 100% of the time albeit it's very niche. Resetting runs manage to show up on the tracker *only* if save and exiting before resetting. 

image Attempting to delete them from within the app does nothing. Closing and reopening the application removes them however: image Them not deleting makes me assume that they aren't actually even there and its just a visual bug caused by the way it updates. Unsure however

aymericingargiola commented 1 year ago

Hello @Shaniquaniminiquani , i will work on reviews i soon as i can (a bit busy actually), thanks !

Shaniquaniminiquani commented 1 year ago

No worries at all, I completely understand if it takes some time to get around to and implement. I added a 4th bullet of something I noticed yesterday to the original comment just to have it all in one place and tried my best to format it a little better as well. Let me know if anything doesn't make sense haha ^^'