aymkam / lucene-gosen

Automatically exported from code.google.com/p/lucene-gosen
GNU Lesser General Public License v2.1
0 stars 0 forks source link

clashes class names in the namespace #27

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Kuromoji* classes will be renamed Japanese* and moved to o.a.l.analysis.ja 
package in coming Lucene 3.6. This will cause trouble for lucene-gosen users, 
name clashes.

I'd propose we rename/move lucene-gosen to something/somewhere. If we will, 
then should we:

1. rename Japanese* classes to something (Gosen*, for example), but don't move 
them?
2. move Japanese* classes in o.a.l.analysis.ja package to somewhere 
(o.a.l.analysis.gosen, for example), but don't rename them?
3. both rename and move?

Shouldn't we stick with org.apache package out of apache.org BTW :) ?

Original issue reported on code.google.com by k...@r.email.ne.jp on 25 Mar 2012 at 2:41

GoogleCodeExporter commented 8 years ago
If we change names, will the release be 2.0?

Original comment by k...@r.email.ne.jp on 25 Mar 2012 at 2:43

GoogleCodeExporter commented 8 years ago
The ticket: https://issues.apache.org/jira/browse/LUCENE-3909

Original comment by k...@r.email.ne.jp on 25 Mar 2012 at 3:02

GoogleCodeExporter commented 8 years ago
> 3. both rename and move?
+1

If we don't move package, the class which we created may conflict with the 
class of Kuromoji in the future.

> If we change names, will the release be 2.0?
+1

Original comment by johtani on 26 Mar 2012 at 2:03

GoogleCodeExporter commented 8 years ago
I will move classes in o.a.l.analysis.ja to o.a.l.analysis.gosen.
And rename Japanese* classes to Gosen* in o.a.l.analysis.ja and o.a.s.analysis.

I will change only trunk and branch_4x.
Rel-1.2 branch don't change the package and classes.

I will do this work tonight. 

Original comment by johtani on 26 Mar 2012 at 5:50

GoogleCodeExporter commented 8 years ago
Commit r175 in trunk, only. yet not change branch_4x.

Testcase all ok and check to using example/schema.xml.snippet to 3.6 nightly 
build.

Original comment by johtani on 26 Mar 2012 at 4:49

GoogleCodeExporter commented 8 years ago

Original comment by johtani on 26 Mar 2012 at 4:50

GoogleCodeExporter commented 8 years ago
release 2.0.0. r178

Original comment by johtani on 2 Apr 2012 at 11:04

GoogleCodeExporter commented 8 years ago
commit r185 branch 4x

Original comment by johtani on 3 Apr 2012 at 12:06