search

ayohrling / local_security_policy

Apache License 2.0
6 stars 28 forks source link

Add parameter support to local_security_policy class for Hiera #101

Closed silug closed 4 years ago

silug commented 4 years ago

Also clean up README.md and add a generated REFERENCE.md.

silug commented 4 years ago

This all LGTM; I would say we should probably update the rspec unit tests for the base class to minimally test the deep merge lookup option, but otherwise looks good

I agree, but unfortunately the way we have everything stubbed out, I couldn't figure out how to write that test in a reasonable way.

I wonder if the stubbing should be moved to spec_helper_acceptance.rb so we can ignore it in the tests themselves?