ayojs / ayo

A fork of Node.js. Humans before technology.
Other
1.66k stars 97 forks source link

src: relax handling of write wrap during cleanup #133

Closed addaleax closed 6 years ago

addaleax commented 6 years ago

One of the HTTP2 tests that are being updated upstream in Node.js leaves around a WriteWrap instance that is not passed over to libuv and therefore can’t be cleaned up.

Address that issue by properly implementing delete self; for WriteWraps using the existing Dispose().

Checklist
Affected core subsystem(s)

src

addaleax commented 6 years ago

Landed in 1d01ddbe1e5bdf48a2e866d1bac307a6e7a24e96