search

ayooby / react-native-calendar-heatmap

React-native calendar heat-map, inspired by Github's contribution graph
152 stars 31 forks source link

Unify version for React and React-Native #11

Open mnlbox opened 4 years ago

mnlbox commented 4 years ago

Hi guys, As I see in package.json it seems this package has a little dependency to React-Native. Just a react-native-svg package rather than web svg and a ScrollView and some styles. https://github.com/ayooby/react-native-calendar-heatmap/blob/237cdd79e334176461b812bda954e6be03b4593b/package.json#L27 https://github.com/ayooby/react-native-calendar-heatmap/blob/237cdd79e334176461b812bda954e6be03b4593b/lib/src/CalendarHeatmap.js#L4

Is it possible to get these values as some props and unify this package and React Version? For example some prop like: svg-g-component then we can pass <g /> in react and <G /> from react-native-svg in react-native apps. We can also have some default value. I think it's simpler to maintain just one package. It's just a question guys :wink: I don't know is it possible or not. :thinking:
I ask because I see this approach in some package for example: https://github.com/pinqy520/mobx-persist#createconfig

WrathChaos commented 4 years ago

Nice idea! I will look for it :)

WrathChaos commented 4 years ago

@ayooby If you have time, can you take care of this issue? I'm having a touch week

ayooby commented 4 years ago

@WrathChaos Hey,

I just migrated to Copenhagen and I have too many things to do(sorry). maybe on holidays.