search

ayoung19 / clipboard-history

A Chrome extension for managing your clipboard history securely, efficiently, and effortlessly.
https://chromewebstore.google.com/detail/clipboard-history-pro-sec/ombhfdknibjljckajldielimdjcomcek?hl=en
Apache License 2.0
23 stars 4 forks source link

Added empty state messages #28

Closed morph1nX closed 3 weeks ago

morph1nX commented 1 month ago

Fixes Issue #6 Please see if everything looks and functions as expected. The code structure might need some more help. Working on it.

morph1nX commented 1 month ago

I moved the rendering logic to the respective page components and removed the inline styles. However I am not using the sx prop to style as the Stack component provides props like h, w, justify and align which is enough for me. Also I see that the component responds to theme changes anyways. What do you think? I have never used Mantine before lol. So thanks for the tips.

ayoung19 commented 1 month ago

No worries! It always takes time getting used to new libraries. I like Mantine because it's extremely customizable so it'll be very helpful if we do a redesign in the future.

Also using those props is fine, it's equivalent to using sx I think. What I meant by theme is stuff like common padding values (xs, md, etc) and the sort.

ayoung19 commented 1 month ago

Looks good! Just a few more nits, thank you so much for working through these!

morph1nX commented 1 month ago

Made NoEntriesOverlay its own component. I too had thought about this first but all the props passing put me off. Anyways I hope this approach works!