search

ayroblu / ssr-create-react-app-v2

This is the v2, its much better written, and uses react-router v4, which is actually pretty nice
230 stars 50 forks source link

Icon downloads on every route change #20

Open dmbaranov opened 7 years ago

dmbaranov commented 7 years ago

First of all, let me say thanks for this awesome work! You implemented a great idea of using CRA without ejecting it together with SSR, really like it! (If there would be a HMR I would like it even more! Because now I have to re-build client part every time I change it).

But one thing I noticed is that icon is downloading again and again each time you change the route. Not sure what causes this behaviour, but probably you do. It's not a big problem though, but would be cool to fix it somehow. Thanks!

screen shot 2017-09-15 at 01 33 13
ayroblu commented 7 years ago

Without looking at the source code, I'm guessing the favicon doesn't exist so it's sending the raw HTML which isn't cached and no 404 right now

dmbaranov commented 7 years ago

Well, actually this screenshot was taken from the freshly installed code of this repository :)

ayroblu commented 7 years ago

Yeah that's what I'm saying, my code probably doesn't have it, feel free to put your own favicon in there and try again