search

ayrton / react-key-handler

React component to handle keyboard events :key:
http://ayrton.be/react-key-handler
388 stars 29 forks source link

Fix PropTypes deprecation warnings #103

Closed HedgeHogBy closed 7 years ago

HedgeHogBy commented 7 years ago

PropTypes are becoming deprecated in React v16.0.0 and are hitting warnings in React v15.5.0, migration guide.

emgeee commented 7 years ago

Any chance of this getting merged soon?

ayrton commented 7 years ago

Thanks for your pull request, I'll try and have a look this weekend to merge this in and publish the package.

zorahrel commented 7 years ago

@ayrton we need this :D

riccardolardi commented 7 years ago

Any merge happening soon?

lhnrd commented 7 years ago

Any updates on this?

lostboy commented 7 years ago

This would be a great pr to merge, its the last package in my build not compatible with react 16 because of the proptypes dep. Crossing fingers.

ayrton commented 7 years ago

I would really love to merge this in but as mentioned in https://github.com/ayrton/react-key-handler/issues/104#issuecomment-308878052 I wonder what needs to be done about backwards compatibility and how other libraries handle this. As soon as I know this I'm happy to release a new version supporting the latest version of React.

HedgeHogBy commented 7 years ago

According to migration guide I mentioned:

The propTypes, contextTypes, and childContextTypes APIs will work exactly as before. The only change is that the built-in validators now live in a separate package.

I hope it could help somehow :)

lostboy commented 7 years ago

@ayrton from what i've seen other maintainers have upgraded their projects with no compatibility issues. Example from react-measure https://github.com/souporserious/react-measure/commit/7bd868217bf24e947290c1cca703d31d6947cb7c

Your existing npm versions will work as is and all future versions will use PropTypes which has the same API as @HedgeHogBy pointed out.

ayrton commented 7 years ago

Thanks, will look tonight to get this merged in and publish a new version

On 28 Aug 2017, at 17:12, lostboy notifications@github.com wrote:

@ayrton from what i've seen other maintainers have upgraded their projects with no compatibility issues. Example from react-measure souporserious/react-measure@7bd8682

Your existing npm versions will work as is and all future versions will use PropTypes which has the same API as @HedgeHogBy pointed out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.