search

ayrton / react-key-handler

React component to handle keyboard events :key:
http://ayrton.be/react-key-handler
388 stars 29 forks source link

Update code according to React 15.5 #104

Closed HedgeHogBy closed 7 years ago

HedgeHogBy commented 7 years ago

Hello, Ayrton!

As you most likely know, React was updated to 15.5 and React.PropTypes and React.createClass were extracted into their own packages. So now React shows warning in case you use PropTypes in the old way. Here you can find details.

I made a small pull request #103 to fix this. It would be great if you could find a time to check and merge it and release a new version with React 15.5 support.

ayrton commented 7 years ago

@HedgeHogBy I'll see if I can find the time to look at your PR this weekend. Thanks for your contribution :)

HedgeHogBy commented 7 years ago

@ayrton Great! Thank you!

silviopaganini commented 7 years ago

any updates on this? would be great to see this update ! thanks !

mikecx commented 7 years ago

Looking for this as well, trying to get fully ready for React 16!

ayrton commented 7 years ago

Can someone verify the PR is 100% what we need? What about backwards compatibility etc

ayrton commented 7 years ago

Fixed in v1.0.0. If something is wrong, please open a new issue.