Open prismofeverything opened 5 years ago
The function bipartite-color will fail (non-deterministically!) for digraphs if it contains at least one node with no outgoing edges due to the use of successors here: https://github.com/aysylu/loom/blob/master/src/loom/alg.cljc#L438
bipartite-color
successors
There is discussion on this issue here (it was discovered while attempting to use ubergraph): https://github.com/Engelberg/ubergraph/issues/35
ubergraph
I have submitted a PR with a fix here: https://github.com/aysylu/loom/pull/117
I find the solution simple and straightforward, but I would appreciate any feedback from the Loom team about this as I know there may be larger considerations I am missing. Thanks!
The function
bipartite-colorwill fail (non-deterministically!) for digraphs if it contains at least one node with no outgoing edges due to the use ofsuccessorshere: https://github.com/aysylu/loom/blob/master/src/loom/alg.cljc#L438There is discussion on this issue here (it was discovered while attempting to use
ubergraph): https://github.com/Engelberg/ubergraph/issues/35I have submitted a PR with a fix here: https://github.com/aysylu/loom/pull/117
I find the solution simple and straightforward, but I would appreciate any feedback from the Loom team about this as I know there may be larger considerations I am missing. Thanks!