ayu-theme / vscode-ayu

ayu theme for vscode
https://marketplace.visualstudio.com/items?itemName=teabyii.ayu
MIT License
585 stars 93 forks source link

Old color scheme? #123

Open sobolevn opened 3 years ago

sobolevn commented 3 years ago

Hi! Thanks a lot for the awesome theme. I am using it for like 4 years now. Dotfiles: https://github.com/sobolevn/dotfiles#vs-code

My main question is: after a recent update (1-2 days ago) my color scheme has changed a lot. And I don't like it, sorry πŸ™‚

Let's discuss new problems I see:

Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2021-09-03 Π² 22 06 44

From top to bottom:

Related https://github.com/dempfi/ayu/issues/250

Is there something you can suggest here? Or should I just fork it?

dempfi commented 3 years ago

4 years is really a lot of time. I'm happy to hear people loving and using ayu ❀️

Thank for detailed report, it seems all of this can be addressed:

dempfi commented 3 years ago

@emlautarom1 when you say

Text used to be yellow, and now is pink-ish.

Do you mean the false constants or something else?

dempfi commented 3 years ago

I've toned down bracket highlights in v1.0.2

xuhaibahmad commented 3 years ago

TYSM for this theme. I use Ayu Dark for pretty much every IDE I use for the past many years.

Please reconsider these recent changes, especially the purple accent. I haven't tried other languages with them yet, but currently, my Dart code looks like this (v1.0.2):

image

dempfi commented 3 years ago

Wow, that's really terrible @xuhaibahmad. Can you share a piece of code for me to test on?

xuhaibahmad commented 3 years ago

Sure! I think the semantic highlighting will have this issue with languages/frameworks that uses object nesting such as Flutter, Kotlin, SwiftUI, and JetPack Compose, etc.

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

class ClickableMaskView extends StatelessWidget {
  const ClickableMaskView({
    Key? key,
    required this.rippleColor,
    required this.onClick,
    required this.padding,
    required this.radius,
  }) : super(key: key);

  final Color rippleColor;
  final Function onClick;
  final double padding;
  final double radius;

  @override
  Widget build(BuildContext context) {
    return Positioned.fill(
      child: Container(
        padding: EdgeInsets.symmetric(horizontal: padding),
        child: Material(
          color: rippleColor,
          child: InkWell(
            onTap: () => onClick.call(),
            borderRadius: BorderRadius.circular(radius),
          ),
        ),
      ),
    );
  }
}
sobolevn commented 3 years ago

The same with python named arguments:

Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2021-09-04 Π² 11 24 13
setup(
    name="django-stubs",
    version="1.8.0",
    description="Mypy stubs for Django",
    long_description=readme,
    long_description_content_type="text/markdown",
    license="MIT",
    url="https://github.com/typeddjango/django-stubs",
    py_modules=[],
    python_requires=">=3.6",
    install_requires=dependencies,
)
sobolevn commented 3 years ago

One more problem: new search is very low on contrast. It is hard to see the highlighted text.

Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2021-09-04 Π² 12 42 32

I really hope that it will be possible to restore things back to normal soon πŸ™‚

dempfi commented 3 years ago

Can you guys give a go to this version ayu-1.0.2.vsix.zip

sobolevn commented 3 years ago

@dempfi thanks a lot! Brackets and keyword arguments are back to normal! πŸ‘ However, function arguments, search results, and constants are still purple for some reason 😞

Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2021-09-04 Π² 22 19 04
xuhaibahmad commented 3 years ago

Much better! Though the use of purple for parameters means a lot of my code is still that color. Also, noticed that parameters are not colored when I disable semantic highlighting.

Semantic Highlighting ON:

image

Semantic Highlighting OFF:

image

sobolevn commented 3 years ago

Ok, I found the solution for my problem. Sharing with other people:

You can use older versions of extensions in vscode. https://stackoverflow.com/questions/42626065/vs-code-rollback-extension-install-specific-extension-version/53755378

Demo (and the final result, code color is back to normal):

https://user-images.githubusercontent.com/4660275/132106037-b87ed8db-7e96-4e98-821c-11ff619e69f2.mov

naivelogic commented 3 years ago

i had to rollback to v0.20.2. love ayu tho!!

exitlol commented 3 years ago

Hope I am not late for the party. @dempfi I work with Angular/TS. And the yellow accent colors are still purple, the type associations are the same color as the Interface

screens from v.1.0.0 and up: image image I think this is the worst part: image

screens from same code before v.1.0.0: image image image

settings.json:

{
    "workbench.colorTheme": "Ayu Dark Bordered",
    "editor.fontLigatures": true,
    "editor.fontFamily": "Fira Code",
    "workbench.iconTheme": "material-icon-theme",
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
    "editor.tabSize": 2,
    "editor.formatOnSave": true,
    "typescript.updateImportsOnFileMove.enabled": "always",
    "editor.codeActionsOnSave": {
        "source.fixAll.tslint": true
    },
    "javascript.updateImportsOnFileMove.enabled": "always",
    "extensions.autoUpdate": false,
    "gitlens.gitCommands.closeOnFocusOut": true,
    "editor.suggestSelection": "first",
    "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
    "bracket-pair-colorizer-2.colors": [
        "Gold",
        "Orchid",
        "LightSkyBlue"
    ],
    "editor.renameOnType": true,
    "workbench.startupEditor": "newUntitledFile",
    "angular.experimental-ivy": true,
    "terminal.integrated.defaultProfile.windows": "Git Bash"
}

If you need snippets or anything else let me know.

emlautarom1 commented 3 years ago

@emlautarom1 when you say

Text used to be yellow, and now is pink-ish.

Do you mean the false constants or something else?

Yes, exactly that. Notice that the constant 2 is also pink-ish

exitlol commented 3 years ago

Any updates in this issue?