search

ayufan-pine64 / linux-build

Pine64 Linux build scripts, tools and instructions (based on Longsleep work)
MIT License
154 stars 36 forks source link

Jenkins conditional release #14

Closed pfeerick closed 7 years ago

pfeerick commented 7 years ago

Would you consider adding this to your Jenkinsfile. Allows for specific make targets to be built, and for github uploads to be skipped. By adding two more parameters and setting the defaults as indicated it will behave exactly as it does now. I find it useful for when wanting just a minimal pinebook build, or xenial-mate-pinebook build, without having to build all the others.

If you're happy with this I'll push another PR for the rock64 build script also, as I've done the same for it.

pfeerick commented 7 years ago

Since you mention Groovy style... your acceptance of a later commit that changes the stage syntax to stage('release') { } etc ?? Since the current syntax is giving deprecation warnings in the jenkins logs... I have it knocking around in my offline git repo, but haven't pushed it to github yet... indents and all ;)

ayufan commented 7 years ago

Yes. Use brackets for stage :)

On Tue, 20 Jun 2017 at 11:55, Peter notifications@github.com wrote:

Since you mention Groovy style... your acceptance of a later commit that changes the stage syntax to stage('release') { } etc ?? Since the current syntax is giving deprecation warnings in the jenkins logs... I have it knocking around in my offline git repo, but haven't pushed it to github yet... indents and all ;)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/ayufan-pine64/linux-build/pull/14#issuecomment-309704769, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTpQRDmvyUMEJwxjBwPToGG12VCKwxIks5sF5cdgaJpZM4N9yYc .

pfeerick commented 7 years ago

Beautiful ;) I'll do that as a separate PR then for that once this one is squared away, so to not pollute the purpose of this one ;)