ayufan-pine64 / linux-build

Pine64 Linux build scripts, tools and instructions (based on Longsleep work)
MIT License
154 stars 36 forks source link

Fix misspelled for pine64-model to pine64_model #43

Closed sujunmin closed 7 years ago

pfeerick commented 7 years ago

I'm actually wondering if it would be better the other way around... i.e. changing it at https://github.com/ayufan-pine64/linux-build/blob/master/simpleimage/make_rootfs.sh#L194 where it is a '_' instead of the '-' , as this will make it consistent with the device tree property... i.e.

/proc/device-tree/chosen/pine64-model

(Had to dig through my emails to find where it was documented, https://github.com/longsleep/u-boot-pine64/commit/cf0f2a7c4088131f35804e03c9a59d788c09246b#diff-05427d73f2e1d6dda5ee427f7c7be23e)

Funmungus commented 7 years ago

I would not know the best place, but if the file name is changed then so must the pine64_model references in /use/local/sbin/ scripts.

pfeerick commented 7 years ago

Yeah, true... meaning pine64_upgrade_android.sh, pine64_install_to_emmc.sh and pine64_update_uboot.sh would need that changed as well.

sujunmin commented 7 years ago

Ok, I need to revoke this pr or to change them all?

ayufan commented 7 years ago

Yes, please

sujunmin commented 7 years ago

I found these 3 files (pine64_upgrade_android.sh, pine64_install_to_emmc.sh and pine64_update_uboot.sh) and there is only pine64_model (cat /etc/pine64_model), not pine64-model.

ayufan commented 7 years ago

Could you either update this PR or close it?

sujunmin commented 7 years ago

I've updated, I found these 3 files (pine64_upgrade_android.sh, pine64_install_to_emmc.sh and pine64_update_uboot.sh) and there is only pine64_model (cat /etc/pine64_model), not pine64-model.

ayufan commented 7 years ago

Awesome. Thanks :)