ayufan-rock64 / pinebook-pro-keyboard-updater

A keyboard/touchpad firmware updater tool
47 stars 21 forks source link

usb_touchpad: Fail if retry counter reaches three #15

Closed TobleMiner closed 4 years ago

TobleMiner commented 4 years ago

Previously the retry counter was checked against 20 which it could not reach, even if the touchpad is not enumerating. This resulted in a segfault without a concise error message.

TobleMiner commented 4 years ago

poke

Would someone care to merge this, please? Random segfaults are not the must fun thing to have.

m42uko commented 4 years ago

I think you're better off opening a PR against jackhumbert's (reverse engineering) fork of this repo. From what I can see, that's where the current development is going on, and he's still actively maintaining his fork. https://github.com/jackhumbert/pinebook-pro-keyboard-updater

ayufan commented 4 years ago

Thanks :) merged :)