search

ayufan / camera-streamer

High-performance low-latency camera streamer for Raspberry PI's
291 stars 46 forks source link

fix: fix `make install` missing file #119

Closed Neko-vecter closed 7 months ago

Neko-vecter commented 7 months ago

File Change:

Fix the missing version.h file when using make install directly.

How to reproduce the problem. git clone the repo and update submodule in the repo. Then run the following command in camera-streamer directory. 

sudo make install

After make install it will show missing version.h

It relate to the issue ayufan/camera-streamer issue 111 and mainsail-crew/crowsnest issue 188

After this fix it can build with crowsnest.

-Neko.vecter

Neko-vecter commented 7 months ago

Since move this version in %: version cmd/% $(TARGET_OBJS) is not working. it will show the message below

/usr/bin/ld: cannot find version: No such file or directory

So... the fix should be like the first commit I make.

Test Device: Raspberry Pi 4B (4GB ver.) with bookworm 64 (Debian 12)

-Neko.vecter

ayufan commented 7 months ago

Move version at the end, not beginning. This should work then.

On Thu, 30 Nov 2023 at 18:15, Neko.vecter @.***> wrote:

Since move this version in %: version cmd/% $(TARGET_OBJS) is not working. it will show the message below

/usr/bin/ld: cannot find version: No such file or directory

So... the fix should be like the first commit I make.

Test Device: Raspberry Pi 4B (4GB ver.) with bookworm 64 (Debian 12)

-Neko.vecter

— Reply to this email directly, view it on GitHub https://github.com/ayufan/camera-streamer/pull/119#issuecomment-1834195234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASOSQOHTEVWELKGMNSID5LYHC5KFAVCNFSM6AAAAABABBXS62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGE4TKMRTGQ . You are receiving this because you commented.Message ID: @.***>

Neko-vecter commented 7 months ago

Move version at the end, not beginning. This should work then. … On Thu, 30 Nov 2023 at 18:15, Neko.vecter @.> wrote: Since move this version in %: version cmd/% $(TARGET_OBJS) is not working. it will show the message below /usr/bin/ld: cannot find version: No such file or directory So... the fix should be like the first commit I make. Test Device: Raspberry Pi 4B (4GB ver.) with bookworm 64 (Debian 12) -Neko.vecter — Reply to this email directly, view it on GitHub <#119 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASOSQOHTEVWELKGMNSID5LYHC5KFAVCNFSM6AAAAABABBXS62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGE4TKMRTGQ . You are receiving this because you commented.Message ID: @.>

it not work. I made change like below

%: cmd/% $(TARGET_OBJS) version

and show

/usr/bin/ld: cannot find version: No such file or directory
collect2: error: ld returned 1 exit status

I think it only work add in install:? Like below.

install: version $(TARGET)

-Neko.vecter

ayufan commented 7 months ago

@Neko-vecter I will look at this tomorrow and add this to a target.

Neko-vecter commented 7 months ago

@Neko-vecter I will look at this tomorrow and add this to a target.

Ok! Have a nice day~

-Neko.vecter

Neko-vecter commented 7 months ago

@Neko-vecter I will look at this tomorrow and add this to a target.

I am thinking let crowsnest using camera-streamer pre-build package. I just open a feature request in mainsail-crew/crowsnest.

-Neko.vecter

ayufan commented 7 months ago

@Neko-vecter I fixed this in https://github.com/ayufan/camera-streamer/commit/54bdd9d4d6a2c67291ecc419cc482423605dedea.