search

ayufan / camera-streamer

High-performance low-latency camera streamer for Raspberry PI's
293 stars 46 forks source link

Add option to specify IP address to bind for HTTP server. #54

Closed AndrolGenhald closed 1 year ago

AndrolGenhald commented 1 year ago

I want to have this behind a reverse proxy that provides authentication, so I added the option to specify the IP address to bind so that I can use --http-addr=127.0.0.1. Listening on a unix domain socket would be even better, but that's a much bigger change that I don't have the time or understanding for at the moment.

Thanks for creating this by the way, I had a lot of trouble with my raspi camera after upgrading to debian bullseye, and this is the first streamer I was actually able to get to work.

RemiNV commented 1 year ago

+1 to this change, I don't feel very comfortable having a brand new C daemon bound to INADDR_ANY, so I think it's a must-have.

It would also be interesting to consider allowing specifying IPv6 addresses (for example, --http-addr=fe80::123:456:789 or --http-addr=::), although this may be better introduced in a different commit.

ayufan commented 1 year ago

@AndrolGenhald @RemiNV happy to merge this once it is improved. I think this fixed buffer is way to small. If we would support larger, and maybe add ipv6 support, I think this is worthy addition.

AndrolGenhald commented 1 year ago

I made the buffer big enough to support all IPV4 addresses, but I'll see if I can add IPV6 support later. I think the segfault should be addressed separately, I did notice that issue but it also exists for the other arguments.

Edit: NVM, just saw you got it done yourself. Thanks!