ayufan / steam-deck-tools

(Windows) Steam Deck Tools - Fan, Overlay, Power Control and Steam Controller for Windows
https://steam-deck-tools.ayufan.dev
Other
867 stars 63 forks source link

Silent Fan profile added (v2.0) #144

Closed Adravil closed 10 months ago

Adravil commented 11 months ago

More upgrades to Silent Fan profile.

ayufan commented 11 months ago

@Adravil This seems like a very complicated piece of code that I believe pushes too much understanding on the user what happens:

ayufan commented 11 months ago

Also, 11W, 13W and 14W TDP values were returned back for precise TDP adjustments (for the same SemiSilent Fan profile, for example).

Unsure of that. The idea was to to avoid adding those higher TDPs, but might consider this as a separate PR.

Adravil commented 10 months ago

@Adravil This seems like a very complicated piece of code that I believe pushes too much understanding on the user what happens:

* Can we just have a single Silent profile that if system power goes over 10W will have slightly different cure? All, being done from perspective of FanControl.

* I believe it would be enough, since if system will consume more than 11W we could force some 2500-3000RPM minimum.

* In this case the `Silent` will be truly silent on low TDP, but will not less silent on higher power and thus safer.
Adravil commented 10 months ago

Also, 11W, 13W and 14W TDP values were returned back for precise TDP adjustments (for the same SemiSilent Fan profile, for example).

Unsure of that. The idea was to to avoid adding those higher TDPs, but might consider this as a separate PR.

... rollback PR 141 and leave TDP options as they are.

Adravil commented 10 months ago

Sorry for the late reply, been busy a bit.

ayufan commented 10 months ago

@Adravil

We could make Silent to increase RPM over some actual TDP, but make the threshold configurable via .ini, and document this. For you and others aware of risks, people could modify FanControl.ini to set SilentPowerThreshold=15 to move the curve up, but keep a default conservative of SilentPowerThreshold=10 or 11.

Adravil commented 10 months ago

@Adravil

We could make Silent to increase RPM over some actual TDP, but make the threshold configurable via .ini, and document this. For you and others aware of risks, people could modify FanControl.ini to set SilentPowerThreshold=15 to move the curve up, but keep a default conservative of SilentPowerThreshold=10 or 11.

That's doable too, tankfully such dependency will be linear (°C to RPM, not W to RPM, but we'll see):

To my understanding you'd like this property to not be displayed and configurable through UI to prevent harm, right? If so, I agree, that'd be a good balance.

Working on it.

Adravil commented 10 months ago

Closing, preparing v3.0 PR.