ayush5harma / PixelFeatureDrops

Magisk Module for Pixel Feature Drops that adds the system files for the same and spoof using the latest device fingerprint from Google Pixel .
MIT License
341 stars 16 forks source link

Unlimited Original Google Photos upload #63

Open rrevanth opened 3 years ago

rrevanth commented 3 years ago

Thanks for doing what you do. This has been awesome module to have on OOS.

Some custom roms like Pixel Experience and Evolution has unlimited original quality google photos uploads. Is it possible to get that feature with this module or am I just speaking non sense :)

ayush5harma commented 3 years ago

Hi, to fix brightness slider issue in OOS the following prop lines were removed

ro.product.vendor.device=redfin
ro.product.vendor.manufacturer=Google

Instead of this try the lsposed module to specifically override device variables for SystemUI - https://github.com/ikws4/WeiJu/releases

That way the system.prop spoof will remain intact and google photos unlimited storage will enable(clearing app data).

The steps for WeiJu are -

Its untested. Please tell if worked.

rrevanth commented 3 years ago

Hi,

I cannot see an option to set the value but enabling that isn't fixing the issue

Screenshot_20210820-175123

rrevanth commented 3 years ago

Also,

High quality uploads are working even without Xposed module and just removing the vendor props.

I was wondering if there is a way if we can get Original quality unlimited photos like on Pixel Experience.

I have no clue how they got that but thinking if you might know.

ayush5harma commented 3 years ago

It offers original quality unlimited uploads? Maybe pixel 1 fingerprint could because it was the only pixel launched with such promise. The evox builds for my device doesn't offer it. Also latest pixels too have unlimited hight quality uploads only post policy change.

rrevanth commented 3 years ago

Yup. I would imagine that's the case but it only shows up in photos but the rest of the device thinks it as pixel 5 like find my device and all.

Screenshot_20210823-142924_Photos__01

I downloaded a module that makes photos think it's pixel but the uploads are still getting counted towards storage. So I guess I have to adjust with high quality 😞

Viraj8456 commented 3 years ago

I'm using PE+11 with my phone's original build prop and fingerprint and I'm still getting unlimited storage at original quality in Google photos... I wonder what they have done..🤷🏻‍♂️ And also my device is registered as Pixel 5 on Find my device....

On Mon, 23 Aug, 2021, 1:23 am Ayush Sharma, @.***> wrote:

It offers original quality unlimited uploads? Maybe pixel 1 fingerprint could because it was the only pixel launched with such promise. The evox builds for my device doesn't offer it. Also latest pixels too have unlimited hight quality uploads only post policy change.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ayush5harma/PixelFeatureDrops/issues/63#issuecomment-903321646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIUPNYDWYZ5ITFWMQCTEOU3T6FITJANCNFSM5CPJCOMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

ayush5harma commented 3 years ago

Yup. I would imagine that's the case but it only shows up in photos but the rest of the device thinks it as pixel 5 like find my device and all.

Screenshot_20210823-142924_Photos__01

I downloaded a module that makes photos think it's pixel but the uploads are still getting counted towards storage. So I guess I have to adjust with high quality

image

Yup that's the first pixel in your case. So unlimited original quality uploads works that way ? The first pixel is promised lifetime original quality uploads other than that pixel 3 is going to have original quality unlimited uploads till January 2022. All rest pixel included pixel 5 are going to have unlimited uploads at storage-saver quality .

ayush5harma commented 3 years ago

I'm using PE+11 with my phone's original build prop and fingerprint and I'm still getting unlimited storage at original quality in Google photos... I wonder what they have done..🤷🏻‍♂️ And also my device is registered as Pixel 5 on Find my device.... On Mon, 23 Aug, 2021, 1:23 am Ayush Sharma, @.***> wrote: It offers original quality unlimited uploads? Maybe pixel 1 fingerprint could because it was the only pixel launched with such promise. The evox builds for my device doesn't offer it. Also latest pixels too have unlimited hight quality uploads only post policy change. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIUPNYDWYZ5ITFWMQCTEOU3T6FITJANCNFSM5CPJCOMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Hi, can you share your photos settings screenshot like the above ones. Just to know if it's custom prop overridden for photos only.

Viraj8456 commented 3 years ago

I'm using PE+11 with my phone's original build prop and fingerprint and I'm still getting unlimited storage at original quality in Google photos... I wonder what they have done..🤷🏻‍♂️ And also my device is registered as Pixel 5 on Find my device.... On Mon, 23 Aug, 2021, 1:23 am Ayush Sharma, @.***> wrote: It offers original quality unlimited uploads? Maybe pixel 1 fingerprint could because it was the only pixel launched with such promise. The evox builds for my device doesn't offer it. Also latest pixels too have unlimited hight quality uploads only post policy change. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIUPNYDWYZ5ITFWMQCTEOU3T6FITJANCNFSM5CPJCOMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Hi, can you share your photos settings screenshot like the above ones. Just to know if it's custom prop overridden for photos only.

Screenshot_20210824-142536_Photos~2

Here it is...

ayush5harma commented 3 years ago

Hi,

I cannot see an option to set the value but enabling that isn't fixing the issue

Screenshot_20210820-175123

I'll try to rebuild WeiJu adding those vendor related variable fields currently spoofing which are causing issues with brightness slider. It will also help zgcam issue on samsung and the xiaomi pop out camera during issue.

rrevanth commented 3 years ago

Yup. I would imagine that's the case but it only shows up in photos but the rest of the device thinks it as pixel 5 like find my device and all. Screenshot_20210823-142924_Photos__01 I downloaded a module that makes photos think it's pixel but the uploads are still getting counted towards storage. So I guess I have to adjust with high quality

image

Yup that's the first pixel in your case. So unlimited original quality uploads works that way ? The first pixel is promised lifetime original quality uploads other than that pixel 3 is going to have original quality unlimited uploads till January 2022. All rest pixel included pixel 5 are going to have unlimited uploads at storage-saver quality .

Yup. I am not sure if it's just props that's going to make it work like that. But if you are able to add all the props replicating via the app. I would love to try that out in OOS since I'm getting mediocre battery life in Custom roms :(

and my phone actually shows up as Oneplus 8T in find my device when using PE or Evo X, where as when I use your module in OOS it imitates Pixel 5. Don't know if that helps!

Rihcus commented 2 years ago

Hi, to fix brightness slider issue in OOS the following prop lines were removed

ro.product.vendor.device=redfin
ro.product.vendor.manufacturer=Google

Instead of this try the lsposed module to specifically override device variables for SystemUI - https://github.com/ikws4/WeiJu/releases

That way the system.prop spoof will remain intact and google photos unlimited storage will enable(clearing app data).

The steps for WeiJu are -

* Install riru from magisk.

* Install lsposed from magisk.

* reboot

* Install WeiJu apk from https://github.com/ikws4/WeiJu/releases.

* Inside LSPosed->Modules->WeiJu- from the three dots menu on the top right uncheck system apps under hide.

* Search for SystemUI and check it (scope of this module).

* Open WeiJu. Inside its settings as well also unhide system apps.(WeiJU -> Settings -> General)

* Select SystemUI.

* It will appear in the main screen. Tap on it to open

* Go inside variable under Expand tool section.

* Here to fill the device related prop values for OOS.

Its untested. Please tell if worked.

system.prop doesn't appear to be needed to trip google photos (I tried with a blank one) and still get unlimited high quality. Call screening doesn't work though oxygen os 11

Smart123s commented 2 years ago

I used to have free Original quality backups, but earlier this month, it disappeared, and now only have free Storage saver backups. I've done some testing, and came to the following conclusion. They have fixed the "bug" in Google Photos 5.62.

Details about my tests:

ROM: Pixel Experience Plus (Android 11) Test date: 2021.10.27 Device: Xiaomi Mi 10 Lite 5G Device (reported by Find My Device): Pixel 5 PixelFeatureDrops was DISABLED in Magisk (I've rebooted the phone before testing)

Google Photos version installed (APK Mirror linked):

maluueu commented 2 years ago

I used to have free Original quality backups, but earlier this month, it disappeared, and now only have free Storage saver backups. I've done some testing, and came to the following conclusion. They have fixed the "bug" in Google Photos 5.62.

Details about my tests:

ROM: Pixel Experience Plus (Android 11) Test date: 2021.10.27 Device: Xiaomi Mi 10 Lite 5G Device (reported by Find My Device): Pixel 5 PixelFeatureDrops was DISABLED in Magisk (I've rebooted the phone before testing)

Google Photos version installed (APK Mirror linked):

I'm the unofficial maintainer for your device, you're right, the only fix right now is to downgrade to an older app version. Google now checks additional props or xml files which we don't now yet.

Tachi107 commented 2 years ago

Does anybody know which properties are checked for the free storage saver backups? I'm unable to get unlimited storage on my Pixel 4 when running GrapheneOS, because they probably didn't include some properties present the stock OS

Smart123s commented 2 years ago

For me, this worked: https://github.com/BaltiApps/Pixelify-Google-Photos I had to set everything to Pixel or Pixel XL

Tachi107 commented 2 years ago

I'm looking for the exact properties needed so that I can embed them into the OS image and avoid having to use Xposed/Magisk/etc, but thanks for the hint :)

Smart123s commented 2 years ago

You can still check out the app (or it's source), it can give you a hint.

In the app, I had to select the Pixel XL build prop, with the Pixel 2016 feature set (and disabled everything else).

On Thu, Mar 10, 2022, 13:47 Andrea Pappacoda @.***> wrote:

I'm looking for the exact properties needed so that I can embed them into the OS image and avoid having to use Xposed/Magisk/etc, but thanks for the hint :)

— Reply to this email directly, view it on GitHub https://github.com/ayush5harma/PixelFeatureDrops/issues/63#issuecomment-1064018000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZJFZCGUMWASQZIVVDFSULU7HVMFANCNFSM5CPJCOMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>