ayushagg31 / Trellis

A simplified Trello clone built with React, Redux, Node, Express and MongoDB.

https://trellis-app.herokuapp.com

GNU General Public License v3.0

127 stars 54 forks source link

Closed hsteinmueller closed 3 years ago

hsteinmueller commented 3 years ago

26

[x] Setup eslint for React app
[x] Create .eslintrc file
[x] Add rule set, I'll be providing few rule set soon
[x] Update Package.json with lint (initialize eslint for the project) and lint-fix (fix the linting issues)

ayushagg31 commented 3 years ago

React code needs separate linting rules. Your changes are not setting the mentioned rule set. I'll be closing this PR will work on this issue myself.

hsteinmueller commented 3 years ago

React code needs separate linting rules. Your changes are not setting the mentioned rule set. I'll be closing this PR will work on this issue myself.

These rules are applied through

"eslintConfig": {
    "extends": "react-app"
 }

in package.json from the client which was already configured.