ayushagg31
commented
3 years ago This looks good, feel free to move on to other issues. I'll reviewing and updating it soon. Thanks for the contrubution.
Closed jocruz-dev closed 3 years ago
ayushagg31
commented
3 years ago This looks good, feel free to move on to other issues. I'll reviewing and updating it soon. Thanks for the contrubution.
ayushagg31
commented
3 years ago Let me know what are your thoughts on this.
jocruz-dev
commented
3 years ago Ok, looks good, I'll make the change ASAP
jocruz-dev
commented
3 years ago Hi, I've already made the changes, let me know if you need me to change something more
On Thu, Oct 8, 2020, 3:03 AM Ayush Aggarwal notifications@github.com wrote:
- Please remove code of conduct entirely, I don't find it relevant to the project
- Also there's some scope of improvement in the project structure, for now add file structure only for client directory, you can use reference from these projects - https://github.com/kriasoft/Folder-Structure-Conventions, https://github.com/oldboyxx/jira_clone/tree/master/api, https://github.com/oldboyxx/jira_clone/tree/master/client
- Add file structure in a README.md inside client file
Let me know what are your thoughts on this.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ayushagg31/Trellis/pull/29#issuecomment-705402676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFCRU63S4FXUC5R42QION3SJVW3XANCNFSM4SHYFCXQ .
ayushagg31
commented
3 years ago Hi @JoshuaPCruz, some description in file stucture needs improvement, I'll edit your PR over weekend.
Improve Readme and add file structure information to make it more open-source friendly
Issue Reference: https://github.com/ayushagg31/Trellis/issues/9
Changes
Expected Outcome
Additional Information
The link on the README file, is pointing to the main repo, just to keep that in mind