search

ayushagg31 / Trellis

A simplified Trello clone built with React, Redux, Node, Express and MongoDB.
https://trellis-app.herokuapp.com
GNU General Public License v3.0
126 stars 54 forks source link

Add workflow for linter check in PR's #52

Closed ayushagg31 closed 3 years ago

ayushagg31 commented 3 years ago

To make sure that the code in the master branch has the proper style, we need to put in place a basic pipeline, using GitHub Actions, for running linting checks on the javascript code

jacubsmith commented 3 years ago

Happy to take this one

jacubsmith commented 3 years ago

@ayushagg31 how do you feel about adding a pre commit lint check as well?

ayushagg31 commented 3 years ago

Yeah, git precommit hook will be better idea, give this a shot.

jacubsmith commented 3 years ago

Have added it as a workflow and explained my reasoning in the PR - if you agree the next step would be issue #54 and then we can add it in as a pre-commit as well.