ayushagg31 / Trellis

A simplified Trello clone built with React, Redux, Node, Express and MongoDB.
https://trellis-app.herokuapp.com
GNU General Public License v3.0
127 stars 54 forks source link

Add pre-commit workflow #58

Closed jacubsmith closed 3 years ago

jacubsmith commented 3 years ago

Description Adds lint check before a commit is allowed to be submitted.

Fixes # (issue reference) closes #57

Type of change

Checklist

Expected Outcome Linting checks will now be run whenever making a commit

ayushagg31 commented 3 years ago

So basically whenever someone make changes and commits, pre-commit will run lint:all and if it fails it will remove those changes from staging. Is that the idea?

jacubsmith commented 3 years ago

Not quite, before it commits any changes it will run the linter and if it fails you can either fix the linting issues or explicitly commit it with the errors

ayushagg31 commented 3 years ago

cool, it will give us more control over code quality, thanks.