search

ayushdiagarwal / Manga-Scraper

This is a scraper that downloads manga from https://kissmanga.com/. Kissmanga is down now, probably forever, so this doesn't work now.
MIT License
7 stars 2 forks source link

Ordering of downloaded images. #1

Closed kweusuf closed 4 years ago

kweusuf commented 4 years ago

The extracted URLs of all the images don't necessarily ensure the correct ordering of the images being downloaded. Hence the output PDF is all jumbled up.

The correct way to do this would be to save the image by the name extracted from the URL itself(I've observed that extracting name from the section of URL such as "title=MTU3LjM0LjEwMS40OA003___1582366331.png" helps as these are ordered correctly) and then processing them further.

ayushdiagarwal commented 4 years ago

Thanks for posting an issue but the images from the manga are downloaded one at a time like the way it is shown in kissmanga, so there shouldn't be a problem with it. Sill, Can you provide the link of the manga you were downloading, so I can take a look at it and fix it?

ayushdiagarwal commented 4 years ago

As you're not replying and the script is already correct. I'm gonna close this issue in a day, if you face any other problem, I'll be happy to help you out!

kweusuf commented 4 years ago

Hi,

No worries. Go ahead and close the issue if you can't validate it. I just patched the script with what worked for me. If you are sure that your code is working correctly then no need to merge my changes.

Thanks, Eusuf

On Wed, May 27, 2020, 9:20 PM Ayush Agarwal notifications@github.com wrote:

As you're not replying and the script is already correct. I'm gonna close this issue in a day, if you face any other problem, I'll be happy to help you out!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/diayush/Manga-Scraper/issues/1#issuecomment-634755074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCWYGHMWMISRE5IE5S2A4DRTUZFXANCNFSM4NJAFQUQ .

ayushdiagarwal commented 4 years ago

Thanks for posting this issue, I'm sure the script is working as I've read manga using the script. Thank for you checking out this program.