search

ayushn21 / AvatarImageView

DEPRECATED!!! --- Use https://github.com/neone/NDAvatarApp
MIT License
255 stars 37 forks source link

Swift 3 #14

Closed piyush9290 closed 7 years ago

piyush9290 commented 8 years ago

Hello Ayush,

I have updated my code to swift 3.0 but when I try to run, it gives me an legacy swift version error. Later when I convert the dependency code, it gives me so many errors. Could you please check if the it is working or not?

screen shot 2016-09-20 at 4 37 09 pm

ayushn21 commented 8 years ago

Hi Piyush,

This looks like an issue with your project. Please go to the project's build settings and set the "Use Legacy Swift Language Version" setting to "No".

screen shot 2016-09-20 at 9 42 51 pm

If you would like to use Swift 3 with this library, please don't convert the code yourself as it was not a trivial migration. Version 2.0.1 of the library is Swift 3 and available through CocoaPods, please use this version and you shouldn't have any trouble.

Let me know if you have any more problems!

Thanks, Ayush

piyush9290 commented 8 years ago

Hello,

I have changed the project settings as you said but issue is still there.

Thanks, Piyush

ayushn21 commented 8 years ago

Ah, strange. Could you describe your project setup a bit please? Are you using CocoaPods? If you are, is this error in the "Pods" project or your main project?

piyush9290 commented 8 years ago

I'm using CocoaPods. The error is in Pods projects.

screen shot 2016-09-20 at 5 16 44 pm screen shot 2016-09-20 at 5 16 54 pm screen shot 2016-09-20 at 5 17 13 pm screen shot 2016-09-20 at 5 18 43 pm

ayushn21 commented 8 years ago

Ah I see, thanks for the screenshots. I've integrated the library using CocoaPods (as seen in the example project) so it does work. Could you tell me which version of CocoaPods you're using please? I know there are issues with Xcode 8 on older versions. Just run pod --version on Terminal.

ayushn21 commented 8 years ago

Also could you please verify whether the Legacy Swift build setting is correct on the AvatarImageView target on the Pods project?

screen shot 2016-09-20 at 10 24 57 pm
piyush9290 commented 8 years ago

Yeah, AvatarImageView has "Use Legacy Swift Language Version" as Unspecified. Now it's working. Thank You Ayush

drinkius commented 7 years ago

Same problem here, by default the pod was installed with "Unspecified" legacy setting. I think it should be fixed in the pod specification somewhere

ayushn21 commented 7 years ago

@drinkius,

A workaround can be specified in the Podfile, can't do anything in the podspec unfortunately :(

https://github.com/CocoaPods/CocoaPods/issues/5521