search

ayushn21 / AvatarImageView

DEPRECATED!!! --- Use https://github.com/neone/NDAvatarApp
MIT License
255 stars 37 forks source link

Updates #26

Closed wow-such-amazing closed 5 years ago

wow-such-amazing commented 5 years ago

Sorry for pushing everything in 1 commit 🙃 Updated project and workspace to swift 4.2; Auto fixed projects' warnings generated by xcode; Changed podfile. Now example project will always use code from local folder; Fixed autolayout warnings in the console for table view cells; Changed library version in podspecto 2.1.3;

wow-such-amazing commented 5 years ago

Checks failed because it can't be compiled with Xcode 9

wow-such-amazing commented 5 years ago

@ayushn21 Can you please merge any request that updates this pod to swift 4.2? 🙂

ayushn21 commented 5 years ago

@crabman448 Yes! I will do it tonight and publish the update to cocoapods. I really need to sort out my notifications; I don't get emails about PRs and issues so I completely missed this!

wow-such-amazing commented 5 years ago

@ayushn21 Thanks! No worries)

ayushn21 commented 5 years ago

Pretty much everything looks good. Great stuff. Thanks for making these updates!

Just one more thing. Could you please update the Xcode version in .travis.yml to xcode10 so the tests can run before I merge this?

wow-such-amazing commented 5 years ago

hmm 🤔

ayushn21 commented 5 years ago

These failures are more likely to be a quirk with the way the tests are written. I should really be using the Facebook screenshot testing library. I think I'll risk it and merge and just do some manual testing to make sure nothing's broken.

Thanks 👍

wow-such-amazing commented 5 years ago

Cool, thanks :)

ayushn21 commented 5 years ago

Swift 4.2 is now supported in v2.2 which has also been pushed to CocoaPods :D

wow-such-amazing commented 5 years ago

Awesome!