ayushnix / tessen

an interactive menu to autotype and copy pass and gopass data
GNU General Public License v2.0
77 stars 12 forks source link

Username override #1

Closed ejiektpobehuk closed 3 years ago

ejiektpobehuk commented 3 years ago

Right now tessen assumes that username should be taken from a filename. And that's it. It's fine but should not be the only option.

It would be nice to use user or username key to override a filename. Since it's explicitly specified, a user should be quite certain, that it should be used over a filename.

ayushnix commented 3 years ago

It would be nice to use user or username key to override a filename.

This should already be the case. If a user: your-username is present inside a file, it should show up in the menu. It shouldn't be username: your-username though, because tessen assumes username from the filename.

ejiektpobehuk commented 3 years ago

Exactly my point. They are treated like different entities and only one of them is used for the autotype.

Better behaviour is to look for a user key in a file first. Fallback to a filename only when it's not found.

ayushnix commented 3 years ago

Better behaviour is to look for a user key in a file first.

Ah, understood.

So you want autotype to use the username from the file if the user or username key is present inside of it instead of assuming username as the file name, right?

Hmm, makes sense. I'll probably add this functionality since rofi-pass behaves the same way and some people would've chosen to write their usernames inside the file rather than in the filename itself.

Thanks for reporting this.

ayushnix commented 3 years ago

I've added a feature to use custom username key and prefer that instead of the filename if it's present. If a username key isn't present, tessen should fallback to using the basename of the selected file.

Please read the README or the man page for more details. Let me know if anything doesn't work as expected.