search

ayushnix / tessen

an interactive menu to autotype and copy pass and gopass data
GNU General Public License v2.0
74 stars 12 forks source link

Invoke bash with env #15

Closed svrana closed 2 years ago

svrana commented 2 years ago

/bin/bash not available on all distrubutions- NixOS in my case.

ayushnix commented 2 years ago

Hmm, I lean towards using /bin/bash by default since that is what almost all Linux distributions use. If NixOS tries to be stateless and not have /bin/bash, maybe it's better to create a patch for it instead of changing the default shebang? The Makefile can probably be changed to use that patch and change the shebang during installation if needed.

svrana commented 2 years ago

Yes, it's very common to have bash in /bin, but even more common to ship with either gnu or bsd coreutils.

Go check out the code for pass or rofi-pass and you will see that env is preferred. Doing it this way also simplifies testing against different bash versions which may be useful to you down the road.

ayushnix commented 2 years ago

Closing as explained here. This change will be incorporated as an optional patch in the next release.

ayushnix commented 2 years ago

fixed in v2.0.0.